Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the OfficialBuild parameter and related conditional logic from several Azure DevOps pipeline YAMLs, hardcoding them to use OneBranch “Official” templates/settings to reduce drift and configuration complexity.
Changes:
- Removed the
OfficialBuildqueue-time parameter from multiple “Official” pipelines and simplified dependent variables. - Hardcoded
extends.templateto official OneBranch governed templates instead of selecting official/non-official at runtime. - Standardized build naming to always reflect the official path (
prod.true).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.pipelines/PowerShell-vPack-Official.yml |
Removes OfficialBuild parameter and hardcodes use of v2/Microsoft.Official.yml template. |
.pipelines/PowerShell-Release-Official.yml |
Removes OfficialBuild parameter, hardcodes Production environment and official CrossPlat template. |
.pipelines/PowerShell-Release-Official-Azure.yml |
Removes OfficialBuild parameter and hardcodes official CrossPlat template. |
.pipelines/PowerShell-Packages-Official.yml |
Removes OfficialBuild parameter and hardcodes official CrossPlat template (but leaves a broken reference—see PR comments). |
.pipelines/PowerShell-Coordinated_Packages-Official.yml |
Removes OfficialBuild parameter, hardcodes official CrossPlat template, and sets ps_official_build to true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request simplifies and standardizes the build pipeline YAML files by removing the
OfficialBuildparameter and related conditional logic. All pipelines are now hardcoded to use the "official" build templates and settings, reducing complexity and potential for misconfiguration between official and non-official builds.Key changes include:
Pipeline Parameter and Variable Simplification
OfficialBuildparameter from all relevant pipeline YAML files, eliminating conditional logic that switched between official and non-official templates and settings. Pipeline names and variables that previously referencedOfficialBuildare now hardcoded to usetrueor official values. [1] [2] [3] [4] [5] [6]Template Usage Standardization
v2/OneBranch.Official.CrossPlat.yml@onebranchTemplates,v2/Microsoft.Official.yml@onebranchTemplates) instead of selecting a template based on theOfficialBuildparameter or a variable. [1] [2] [3] [4] [5] [6] [7] [8] [9]Consistent Build Naming
OfficialBuildnow usetruedirectly, ensuring consistent naming conventions across all official builds. [1] [2] [3] [4] [5]Environment and Variable Hardcoding
OfficialBuild(e.g.,ps_official_build,releaseEnvironment) are now set to their official values unconditionally, further reducing conditional complexity. [1] [2]These changes make the build pipelines easier to maintain by enforcing a single, official build path and removing unnecessary parameters and branching logic.
PR Context
This is necessary to comply with 1ES Drift Management policy.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header