Skip to content

[release/v7.4] Correct the package name for .deb and .rpm packages (#26877) #26954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jshigetomi merged 1 commit into from
Mar 9, 2026
+9 −4
Merged

[release/v7.4] Correct the package name for .deb and .rpm packages (#26877) #26954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/macos-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jobs:
outputs:
source: ${{ steps.filter.outputs.source }}
buildModuleChanged: ${{ steps.filter.outputs.buildModuleChanged }}
packagingChanged: ${{ steps.filter.outputs.packagingChanged }}
steps:
- name: checkout
uses: actions/checkout@v4.1.0
Expand Down Expand Up @@ -155,7 +156,7 @@ jobs:
name: macOS packaging and testing
needs:
- changes
if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.buildModuleChanged == 'true' }}
if: ${{ needs.changes.outputs.packagingChanged == 'true' }}
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job now runs only when needs.changes.outputs.packagingChanged == 'true', but the path-filters action currently (1) does not set packagingChanged for non-PR events (push/workflow_dispatch) and (2) does not include test/packaging/macos/ (or macos-ci.yml) in its packagingChanged paths. This means macOS packaging validation can be skipped when it should run. Consider either expanding the condition (e.g., include source/buildModuleChanged) or updating the path filter so packagingChanged is computed for these cases (ideally in default branch, then backport).

Suggested change
if: ${{ needs.changes.outputs.packagingChanged == 'true' }}
if: ${{ needs.changes.outputs.packagingChanged == 'true' || needs.changes.outputs.source == 'true' || needs.changes.outputs.buildModuleChanged == 'true' }}

Copilot uses AI. Check for mistakes.
runs-on:
- macos-latest
steps:
Expand Down
10 changes: 7 additions & 3 deletions tools/packaging/packaging.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,12 +1145,16 @@ function New-UnixPackage {
}

# Determine if the version is a preview version
# Only LTS packages get a prefix in the name
# Preview versions are identified by the version string itself (e.g., 7.6.0-preview.6)
# Rebuild versions are also identified by the version string (e.g., 7.4.13-rebuild.5)
$IsPreview = Test-IsPreview -Version $Version -IsLTS:$LTS

# For deb/rpm packages, use the '-lts' and '-preview' channel suffix variants to match existing names on packages.microsoft.com.
# For osxpkg package, only LTS packages get a channel suffix in the name.
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar nit in comment: “For osxpkg package” should be “For osxpkg packages” (or “For the osxpkg package type”).

Suggested change
# For osxpkg package, only LTS packages get a channel suffix in the name.
# For osxpkg packages, only LTS packages get a channel suffix in the name.

Copilot uses AI. Check for mistakes.
$Name = if($LTS) {
"powershell-lts"
}
elseif ($IsPreview -and $Type -ne "osxpkg") {
"powershell-preview"
}
else {
"powershell"
}
Expand Down
Loading