Skip to content

Select New MSIX Package Name#27096

Merged
jshigetomi merged 1 commit into
PowerShell:masterfrom
jshigetomi:updateMSIXFileSelection
Mar 25, 2026
Merged

Select New MSIX Package Name#27096
jshigetomi merged 1 commit into
PowerShell:masterfrom
jshigetomi:updateMSIXFileSelection

Conversation

@jshigetomi
Copy link
Copy Markdown
Collaborator

@jshigetomi jshigetomi commented Mar 25, 2026

PR Summary

This pull request makes a small but important update to the Windows packaging pipeline. The filter used to find MSIX package files has been changed from a lowercase pattern to a capitalized one to match the actual file naming convention.

  • Updated the $msixPkgNameFilter variable in both .pipelines/templates/packaging/windows/package.yml and .pipelines/templates/packaging/windows/sign.yml from "powershell-*.msix" to "PowerShell*.msix" to ensure the correct MSIX files are found and processed. [1] [2]

PR Context

MSIX file filter does not select for the Preview case where the file name is PowerShellPreview-7.7.99-rebuild.99-win-x64.msix

PR Checklist

@jshigetomi jshigetomi added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 25, 2026
@jshigetomi jshigetomi marked this pull request as ready for review March 25, 2026 18:33
@jshigetomi jshigetomi requested a review from a team as a code owner March 25, 2026 18:33
Copilot AI review requested due to automatic review settings March 25, 2026 18:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows packaging pipeline to correctly locate MSIX artifacts by adjusting the filename filter used during packaging and signing (including Preview MSIX names like PowerShellPreview-...).

Changes:

  • Updated the MSIX filename filter in the Windows sign template.
  • Updated the MSIX filename filter in the Windows package template.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.pipelines/templates/packaging/windows/sign.yml Adjusts the MSIX artifact search filter used when collecting signed MSIX outputs.
.pipelines/templates/packaging/windows/package.yml Adjusts the MSIX artifact search filter used when collecting unsigned MSIX outputs.

Comment thread .pipelines/templates/packaging/windows/sign.yml
Comment thread .pipelines/templates/packaging/windows/package.yml
@jshigetomi jshigetomi enabled auto-merge (squash) March 25, 2026 18:44
@jshigetomi jshigetomi merged commit a17f176 into PowerShell:master Mar 25, 2026
49 of 51 checks passed
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 2, 2026
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 2, 2026
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 2, 2026
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Done Backport-7.5.x-Done Backport-7.6.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants