Skip to content

[release/v7.4.15] Delay update notification for one week to ensure all packages become available #27229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 1 commit into from
Apr 9, 2026
+14 −2
Merged

[release/v7.4.15] Delay update notification for one week to ensure all packages become available #27229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ internal static class UpdatesNotification
private const string StableBuildInfoURL = "https://aka.ms/pwsh-buildinfo-stable";
private const string PreviewBuildInfoURL = "https://aka.ms/pwsh-buildinfo-preview";

private const int NotificationDelayDays = 7;
private const int UpdateCheckBackoffDays = 7;

/// <summary>
/// The version of new update is persisted using a file, not as the file content, but instead baked in the file name in the following template:
/// `update{notification-type}_{version}_{publish-date}` -- held by 's_updateFileNameTemplate',
Expand Down Expand Up @@ -89,9 +92,18 @@ internal static void ShowUpdateNotification(PSHostUserInterface hostUI)
if (TryParseUpdateFile(
updateFilePath: out _,
out SemanticVersion lastUpdateVersion,
lastUpdateDate: out _)
out DateTime lastUpdateDate)
&& lastUpdateVersion != null)
{
DateTime today = DateTime.UtcNow;
if ((today - lastUpdateDate).TotalDays < NotificationDelayDays)
Comment on lines +98 to +99
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastUpdateDate comes from TryParseUpdateFile() which parses a date-only string using DateTimeStyles.AssumeLocal, but this comparison uses DateTime.UtcNow. That mixes local and UTC day boundaries and can shift the effective delay by up to ~1 day depending on the user's timezone. Consider comparing using a consistent basis (e.g., compare DateTime.Today to lastUpdateDate.Date, or parse/normalize lastUpdateDate as UTC and compare to UtcNow.Date).

Suggested change
DateTime today = DateTime.UtcNow;
if ((today - lastUpdateDate).TotalDays < NotificationDelayDays)
DateTime today = DateTime.Today;
if ((today - lastUpdateDate.Date).TotalDays < NotificationDelayDays)

Copilot uses AI. Check for mistakes.
{
// The update was out less than 1 week ago and it's possible the packages are still rolling out.
// We only show the notification when the update is at least 1 week old, to reduce the chance that
// users see the notification but cannot get the new update when they try to install it.
return;
}

string releaseTag = lastUpdateVersion.ToString();
Comment on lines +98 to 107
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the first startup where (today - lastUpdateDate) crosses NotificationDelayDays, ShowUpdateNotification() can show a notification based on a stale update file before CheckForUpdates() has run (it starts in the background and has an initial 3s delay). This can result in prompting for an older release even when a newer one is available. One option is to only show notifications after a successful update check has completed for the current day (e.g., gate on today’s .done file), or otherwise ensure the cache is refreshed before showing once the delay has elapsed.

Copilot uses AI. Check for mistakes.
string notificationMsgTemplate = s_notificationType == NotificationType.LTS
? ManagedEntranceStrings.LTSUpdateNotificationMessage
Expand Down Expand Up @@ -169,7 +181,7 @@ internal static async Task CheckForUpdates()
out DateTime lastUpdateDate);

DateTime today = DateTime.UtcNow;
if (parseSuccess && updateFilePath != null && (today - lastUpdateDate).TotalDays < 7)
if (parseSuccess && updateFilePath != null && (today - lastUpdateDate).TotalDays < UpdateCheckBackoffDays)
{
// There is an existing update file, and the last update was less than 1 week ago.
// It's unlikely a new version is released within 1 week, so we can skip this check.
Expand Down
Loading