[release/v7.4.15] Build, package, and create VPack for the PowerShell-LTS store package within the same `msixbundle-vpack` pipeline (#150) by daxian-dbw · Pull Request #27242 · PowerShell/PowerShell

daxian-dbw · 2026-04-09T21:03:08Z

Backport of #27209 to release/v7.4.15

Triggered by @daxian-dbw on behalf of @daxian-dbw

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

Required tooling change
Optional tooling change (include reasoning)

Updates the release/v7.4.15 MSIXBundle vPack pipeline to build, package, and create the PowerShell-LTS store VPack in the same pipeline, including the related symbol publishing flow required for the release process.

Customer Impact

Customer reported
Found internally

Regression

REQUIRED: Check exactly one box.

Yes
No

This is not a regression.

Testing

The backport was retried from a clean release/v7.4.15 base. Cherry-pick conflicts were resolved by taking the PR version of .pipelines/MSIXBundle-vPack-Official.yml and keeping the release-branch versions of TabCompletionStrings.resx and Telemetry.cs. The resulting backport commit completed successfully and CI on the backport PR will validate the updated packaging pipeline flow.

Risk

REQUIRED: Check exactly one box.

High
Medium
Low

High risk because this materially changes release packaging and VPack infrastructure for the LTS store package, but the change is required to keep the release process compliant and aligned with the intended vPack build flow.

Merge Conflicts

Resolved three cherry-pick conflicts during a fresh retry. Took the PR version of .pipelines/MSIXBundle-vPack-Official.yml in full, and intentionally kept the release-branch versions of src/System.Management.Automation/resources/TabCompletionStrings.resx and src/System.Management.Automation/utils/Telemetry.cs unchanged.

… within the same `msixbundle-vpack` pipeline (PowerShell#150) (PowerShell#27209)

Copilot

Pull request overview

Updates the msixbundle-vpack official pipeline on release/v7.4.15 to build and package the PowerShell-LTS Store MSIX from source, then create/sign the MSIXBundle and publish symbols within the same pipeline (backport of #27209).

Changes:

Reworks .pipelines/MSIXBundle-vPack-Official.yml to build unsigned MSIX (x64/arm64), sign build outputs, bundle + sign MSIXBundle, and publish PDB symbols.
Updates a few product/resource strings and minor code/style tweaks in ConsoleHost/props.
Minor cleanup in tools/packaging/packaging.psm1 comments.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`.pipelines/MSIXBundle-vPack-Official.yml`	Major pipeline redesign to build MSIX packages in-pipeline, create/sign MSIXBundle, create VPack, and publish symbols.
`tools/packaging/packaging.psm1`	Comment cleanup in `New-MSIXPackage`.
`src/System.Management.Automation/resources/RemotingErrorIdStrings.resx`	Updates a remoting error message to “PowerShell 7+”.
`src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx`	Renames the banner resource key used by the console host.
`src/Microsoft.PowerShell.ConsoleHost/host/msh/ManagedEntrance.cs`	Updates banner string usage to the renamed resource key.
`src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs`	Assigns stdout-redirection flag via unqualified static access.
`PowerShell.Common.props`	Minor formatting change in `IsWindows` condition.

Copilot · 2026-04-09T21:10:59Z

+            $outputDir = "$sourceDir\output"
+            New-Item $outputDir -Type Directory -Force > $null


The bundle output directory is created as a subfolder of the input directory ($outputDir = "$sourceDir\output" while /d $sourceDir). Keeping outputs outside the input tree avoids edge cases where makeappx bundle may pick up unintended files/folders. Consider writing the bundle to a sibling directory instead of under $sourceDir.

Suggested change

$outputDir = "$sourceDir\output"

New-Item $outputDir -Type Directory -Force > $null

$outputDir = '$(Pipeline.Workspace)\releasePipeline\msixbundle'

New-Item -Path $outputDir -ItemType Directory -Force > $null

Copilot · 2026-04-09T21:10:59Z

+  - name: WindowsContainerImage
+    value: 'onebranch.azurecr.io/windows/ltsc2022/vse2022:latest'
+  - name: Codeql.Enabled
+    value: false  #  pipeline is not building artifacts; it repackages existing artifacts into a vpack


Codeql.Enabled is set to false with a comment stating the pipeline only repackages artifacts, but this pipeline now performs a full build and also runs CodeQL3000Init/Finalize. The variable/comment combination is misleading and could cause confusion or accidental disabling of expected CodeQL behavior. Update the comment and/or the variable to reflect the current pipeline behavior.

Suggested change

value: false # pipeline is not building artifacts; it repackages existing artifacts into a vpack

value: false # CodeQL is intentionally disabled for this pipeline configuration; update this setting if CodeQL analysis is expected here.

Copilot · 2026-04-09T21:11:00Z

+                $makeappx = Get-ChildItem -Recurse 'C:\Program Files (x86)\Windows Kits\10\makeappx.exe' |
+                  Where-Object { $_.DirectoryName -match 'x64' } |
+                  Select-Object -Last 1
+                $exePath = $makeappx.FullName
+                Write-Verbose -Verbose "makeappx was found: $exePath"
+            }


The fallback search for makeappx.exe uses Get-ChildItem -Recurse 'C:\Program Files (x86)\Windows Kits\10\makeappx.exe', which won’t find the typical Windows SDK layout (usually under ...\Windows Kits\10\bin\<ver>\x64\makeappx.exe). If makeappx isn’t already on PATH, $makeappx will be empty and $exePath will end up null, breaking the subsequent bundle step. Update the search to target the SDK bin tree (or another reliable discovery method) and add an explicit null/empty check with a clear error when the tool can’t be located.

Suggested change

$makeappx = Get-ChildItem -Recurse 'C:\Program Files (x86)\Windows Kits\10\makeappx.exe' |

Where-Object { $_.DirectoryName -match 'x64' } |

Select-Object -Last 1

$exePath = $makeappx.FullName

Write-Verbose -Verbose "makeappx was found: $exePath"

}

$windowsSdkBinPath = 'C:\Program Files (x86)\Windows Kits\10\bin'

$makeappx = Get-ChildItem -Path $windowsSdkBinPath -Filter 'makeappx.exe' -Recurse -File -ErrorAction SilentlyContinue |

Where-Object { $_.FullName -match '[\\/]x64[\\/]' } |

Sort-Object -Property FullName |

Select-Object -Last 1

if ($makeappx) {

$exePath = $makeappx.FullName

Write-Verbose -Verbose "makeappx was found in Windows SDK: $exePath"

}

}

if ([string]::IsNullOrWhiteSpace($exePath)) {

throw "Unable to locate makeappx.exe. The tool was not found on PATH or under '$windowsSdkBinPath'. Ensure the Windows SDK is installed and includes the x64 makeappx.exe tool."

}

Copilot · 2026-04-09T21:11:00Z

+          retryCountOnTaskFailure: 1
+
+        - pwsh: |
+            $sourceDir = '$(Pipeline.Workspace)\releasePipeline\msix'


$sourceDir is created with -Force but its contents are never cleared. If the agent/workspace is reused (or a previous attempt left files behind), stale .msix files could be bundled unintentionally. Consider deleting/recreating the directory (or using a unique per-run folder) before copying the downloaded .msix inputs.

Suggested change

$sourceDir = '$(Pipeline.Workspace)\releasePipeline\msix'

$sourceDir = '$(Pipeline.Workspace)\releasePipeline\msix'

if (Test-Path -Path $sourceDir) {

Remove-Item -Path $sourceDir -Recurse -Force

}

Copilot · 2026-04-09T21:11:00Z

+            search_root: '$(BundleDir)'
+
+        - pwsh: |
+            $signedBundle = Get-ChildItem -Path $(BundleDir) -Filter "*.msixbundle" -File


$signedBundle = Get-ChildItem ... -Filter "*.msixbundle" doesn’t validate the result count. If multiple bundles exist in $(BundleDir), $signedBundle.FullName and the signature validation/copy will behave unpredictably. Add a check that exactly one .msixbundle is present and fail with a clear message otherwise.

Suggested change

$signedBundle = Get-ChildItem -Path $(BundleDir) -Filter "*.msixbundle" -File

$signedBundle = @(Get-ChildItem -Path $(BundleDir) -Filter "*.msixbundle" -File)

if ($signedBundle.Count -ne 1) {

$bundleNames = if ($signedBundle.Count -gt 0) {

($signedBundle | Select-Object -ExpandProperty FullName) -join ', '

}

else {

'<none>'

}

throw "Expected exactly one .msixbundle in $(BundleDir), but found $($signedBundle.Count). Found: $bundleNames"

}

$signedBundle = $signedBundle[0]

Build, package, and create VPack for the PowerShell-LTS store package…

4aefa8b

… within the same `msixbundle-vpack` pipeline (PowerShell#150) (PowerShell#27209)

daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 9, 2026

daxian-dbw requested a review from a team as a code owner April 9, 2026 21:03

Copilot AI review requested due to automatic review settings April 9, 2026 21:03

daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 9, 2026

Copilot started reviewing on behalf of daxian-dbw April 9, 2026 21:05 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

daxian-dbw merged commit cf65293 into PowerShell:release/v7.4.15 Apr 9, 2026
45 checks passed

daxian-dbw deleted the backport/release/v7.4.15/27209-073f4d61b branch April 9, 2026 22:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/v7.4.15] Build, package, and create VPack for the PowerShell-LTS store package within the same `msixbundle-vpack` pipeline (#150)#27242

[release/v7.4.15] Build, package, and create VPack for the PowerShell-LTS store package within the same `msixbundle-vpack` pipeline (#150)#27242
daxian-dbw merged 1 commit into
PowerShell:release/v7.4.15from
daxian-dbw:backport/release/v7.4.15/27209-073f4d61b

daxian-dbw commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		$outputDir = "$sourceDir\output"
		New-Item $outputDir -Type Directory -Force > $null

	value: false # pipeline is not building artifacts; it repackages existing artifacts into a vpack
	value: false # CodeQL is intentionally disabled for this pipeline configuration; update this setting if CodeQL analysis is expected here.

-                $makeappx = Get-ChildItem -Recurse 'C:\Program Files (x86)\Windows Kits\10\makeappx.exe' |
-                  Where-Object { $_.DirectoryName -match 'x64' } |
-                  Select-Object -Last 1
-                $exePath = $makeappx.FullName
-                Write-Verbose -Verbose "makeappx was found: $exePath"
-            }
+                $windowsSdkBinPath = 'C:\Program Files (x86)\Windows Kits\10\bin'
+                $makeappx = Get-ChildItem -Path $windowsSdkBinPath -Filter 'makeappx.exe' -Recurse -File -ErrorAction SilentlyContinue |
+                  Where-Object { $_.FullName -match '[\\/]x64[\\/]' } |
+                  Sort-Object -Property FullName |
+                  Select-Object -Last 1
+                if ($makeappx) {
+                    $exePath = $makeappx.FullName
+                    Write-Verbose -Verbose "makeappx was found in Windows SDK: $exePath"
+                }
+            }
+            if ([string]::IsNullOrWhiteSpace($exePath)) {
+                throw "Unable to locate makeappx.exe. The tool was not found on PATH or under '$windowsSdkBinPath'. Ensure the Windows SDK is installed and includes the x64 makeappx.exe tool."
+            }

-            $signedBundle = Get-ChildItem -Path $(BundleDir) -Filter "*.msixbundle" -File
+            $signedBundle = @(Get-ChildItem -Path $(BundleDir) -Filter "*.msixbundle" -File)
+            if ($signedBundle.Count -ne 1) {
+                $bundleNames = if ($signedBundle.Count -gt 0) {
+                    ($signedBundle | Select-Object -ExpandProperty FullName) -join ', '
+                }
+                else {
+                    '<none>'
+                }
+                throw "Expected exactly one .msixbundle in $(BundleDir), but found $($signedBundle.Count). Found: $bundleNames"
+            }
+            $signedBundle = $signedBundle[0]

Conversation

daxian-dbw commented Apr 9, 2026

Impact

Tooling Impact

Customer Impact

Regression

Testing

Risk

Merge Conflicts

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants