Skip to content

Retry and cache the test framework downloads in CI #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Project516 merged 2 commits into from
Nov 4, 2026
+11 −3
Merged

Retry and cache the test framework downloads in CI #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6271d4
Retry the TestNG and JUnit downloads when Maven Central rate-limits C…
Project516 Nov 4, 2026
a00ae8b
Take BitLengthOverflow out of the CI test list, since it times out on…
Project516 Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/jtreg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ jobs:
~/.cache/java-web/jdk-*
~/.cache/java-web/dejavu-*
key: jdk-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('scripts/build-jdk.sh') }}
# TestNG and JUnit, which scripts/jtreg/run.ts fetches from Maven Central
- uses: actions/cache@v6
with:
path: build/jtreg/lib
key: jtreg-lib-${{ hashFiles('scripts/jtreg/run.ts') }}
- run: pnpm install --frozen-lockfile
- run: pnpm jdk
# each test VM starts from the bundle, which loads faster than src/
Expand Down
7 changes: 6 additions & 1 deletion scripts/jtreg/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,12 @@ async function fetchFrameworks(): Promise<string[]> {
for (const [path, sha1] of frameworkJars) {
const jar = join(lib, path.slice(path.lastIndexOf("/") + 1));
if (!existsSync(jar)) {
const res = await fetch(maven + path);
// Maven Central answers 429 when many CI jobs start at once
let res = await fetch(maven + path);
for (let wait = 5; (res.status === 429 || res.status >= 500) && wait <= 80; wait *= 2) {
await new Promise((r) => setTimeout(r, wait * 1000));
res = await fetch(maven + path);
}
if (!res.ok) throw new Error(`${res.status} fetching ${path}`);
const bytes = Buffer.from(await res.arrayBuffer());
const sum = createHash("sha1").update(bytes).digest("hex");
Expand Down
1 change: 0 additions & 1 deletion test/jtreg/passing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,6 @@ java/math/BigDecimal/ToPlainStringTests.java
java/math/BigDecimal/ValueOfDouble.java
java/math/BigDecimal/ZeroScalingTests.java
java/math/BigInteger/BigIntegerParallelMultiplyTest.java
java/math/BigInteger/BitLengthOverflow.java
java/math/BigInteger/CompareToTests.java
java/math/BigInteger/DoubleValueOverflow.java
java/math/BigInteger/HashCode.java
Expand Down
1 change: 0 additions & 1 deletion test/jtreg/times.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2760,7 +2760,6 @@
2393 java/beans/PropertyEditor/TestEnumSubclassValue.java
2392 java/util/PriorityQueue/RemoveContains.java
2389 java/nio/MappedByteBuffer/ForceViews.java
2389 java/math/BigInteger/BitLengthOverflow.java
2389 java/io/Externalizable/compatibility/ExternalizableBlockData.java
2386 java/security/cert/PKIXBuilderParameters/InvalidParameters.java
2386 java/net/URL/RelativeURLTest.java
Expand Down
Loading