Skip to content

Collect garbage before the java-web command exits, which avoids a hang in node's exit teardown #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Project516 merged 1 commit into from
Nov 5, 2026
+5 −1
Merged

Collect garbage before the java-web command exits, which avoids a hang in node's exit teardown #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,9 @@ export function main(argv: string[]) {
console.error("usage: java-web [-cp path] [-Dkey=value] Main [args] | -jar app.jar [args]");
process.exit(2);
}
Promise.resolve().then(() => runNode(o)).then((code) => process.exit(code), (e) => {
// Collecting first: node's exit teardown can deadlock while it frees very
// large array buffers (seen on x64 CI runners with a few hundred MB left).
Promise.resolve().then(() => runNode(o)).then((code) => (globalThis.gc?.(), process.exit(code)), (e) => {
console.error(`java-web: ${(e as Error).message}`);
process.exit(1);
});
Expand Down
1 change: 1 addition & 0 deletions test/jtreg/passing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,6 +1426,7 @@ java/math/BigDecimal/ToPlainStringTests.java
java/math/BigDecimal/ValueOfDouble.java
java/math/BigDecimal/ZeroScalingTests.java
java/math/BigInteger/BigIntegerParallelMultiplyTest.java
java/math/BigInteger/BitLengthOverflow.java
java/math/BigInteger/CompareToTests.java
java/math/BigInteger/DoubleValueOverflow.java
java/math/BigInteger/HashCode.java
Expand Down
1 change: 1 addition & 0 deletions test/jtreg/times.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2761,6 +2761,7 @@
2392 java/util/PriorityQueue/RemoveContains.java
2389 java/nio/MappedByteBuffer/ForceViews.java
2389 java/io/Externalizable/compatibility/ExternalizableBlockData.java
2389 java/math/BigInteger/BitLengthOverflow.java
2386 java/security/cert/PKIXBuilderParameters/InvalidParameters.java
2386 java/net/URL/RelativeURLTest.java
2385 java/util/HashMap/OverrideIsEmpty.java
Expand Down
Loading