Skip to content

Add --find-renames and --find-copies to the diff command#115

Open
SandrineP wants to merge 1 commit intoQuantStack:mainfrom
SandrineP:diff_find
Open

Add --find-renames and --find-copies to the diff command#115
SandrineP wants to merge 1 commit intoQuantStack:mainfrom
SandrineP:diff_find

Conversation

@SandrineP
Copy link
Collaborator

@SandrineP SandrineP commented Mar 4, 2026

Fix #88
Add --find-renames and --find-copies to the diff command

@codecov
Copy link

codecov bot commented Mar 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.04%. Comparing base (054814f) to head (c3b5ce4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/subcommand/diff_subcommand.cpp 90.19% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   86.83%   87.04%   +0.21%     
==========================================
  Files          60       60              
  Lines        2340     2386      +46     
  Branches      276      289      +13     
==========================================
+ Hits         2032     2077      +45     
- Misses        308      309       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SandrineP SandrineP force-pushed the diff_find branch 3 times, most recently from 3ec66c7 to 7e578d1 Compare March 4, 2026 16:23
ianthomas23
ianthomas23 reviewed Mar 5, 2026
View reviewed changes
src/subcommand/diff_subcommand.cpp
git_diff_options diffopts;
git_diff_options_init(&diffopts, GIT_DIFF_OPTIONS_VERSION);

std::cerr << "DEBUG cached=" << m_cached_flag
Copy link
Member

@ianthomas23 ianthomas23 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you intending to leave this in?

Copy link
Collaborator Author

@SandrineP SandrineP Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ! That's a classic (I thought I removed all the printing for debugging...)

Copy link
Member

@ianthomas23 ianthomas23 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you might be purposefully leaving me something easy to find!

Copy link
Collaborator Author

@SandrineP SandrineP Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I do that in the future, I'll make sure to leave a comment. So far I only (regularly) forgot to remove some prints...

@ianthomas23 ianthomas23 added the enhancement New feature or request label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianthomas23 ianthomas23 ianthomas23 left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement --find-renames and --find-copies in diff command

2 participants

@SandrineP @ianthomas23