Skip to content

ci: add reusable report-only governance engine - #31

Merged
Pigbibi merged 3 commits into
mainfrom
ci/governance-shadow-engine
Nov 3, 2026
Merged

Pigbibi merged 3 commits into
mainfrom
ci/governance-shadow-engine

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Automated implementation assistance in the configured coding host; model provenance follows the job receipt.

What changed

Add one public reusable, read-only review observer and pinned machine policy. The observer checks complete patches and current candidate bindings, recognizes separately configured independent review and owner records, and exports only a minimal SHADOW summary. Existing gates, required checks and repository settings are untouched.

How verified

36 observer tests, 36 documentation-checker tests and 9 secret-scan tests pass. Actionlint, documentation phase 2 (zero blocking findings), staged identifier check, current-tree secret scan and diff checks pass. Adverse cases include one recorded fail-before concrete-defect override regression, plus redaction and snapshot-re-read mutations detected by tests.

Why

Prepare one tool-independent repository-native engine for the two explicitly approved report-only pilots. The current policy identity lists are empty; observations remain pending where review or owner evidence is needed. All results retain merge_authorized=false. Native required-check acceptance, baseline exceptions, durable writer admission, atomic freshness and merge queues remain unsupported. Source preparation is separate from hosted runtime acceptance.

Risk

R2: adds workflows and governance source. No source checkout or execution from a candidate, inherited secrets, write token, status publication, label mutation, merge, deployment or setting change. Keep this PR Draft until current CI is green; owner-governance red checks remain binding. Pilot callers will pin this exact candidate and depend on central integration.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please independently review the current complete diff at head 12b099e26e2231b8db5b31e0a3c316c58839c069. Focus on trustworthy GitHub App provenance, current-head binding, malformed or stale receipt handling, and whether the new observation could be mistaken for merge authorization. This remains SHADOW-only: no approval, owner label, merge or deployment is authorized by this observation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T16:20:39.368178Z d04264d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12b099e26e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please independently re-review the complete current diff at exact head d04264dd91d26cb18b881968816c1df1c3ecd57e. The latest changes explicitly document that organization-wide policy requires the owner's request and a reviewed change; the owner requested governance across the three organizations. Duplicate Codex receipt blocks now produce UNKNOWN, and comment-only reviews cannot erase an unresolved change request. Added regressions first reproduced all three issues and now pass; 53 shadow tests, workflow YAML parsing, actionlint, and style checks pass. This remains SHADOW-only: the default App identity list is empty, it cannot authorize merge, and it does not change deployment or trading permissions. Please report any unresolved defect or coverage limit.

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: d04264dd91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi Pigbibi added the owner-approved Owner approval. Under Li SiYi's authorization the review bot may apply it after clean review; logged label Nov 3, 2026
@Pigbibi
Pigbibi marked this pull request as ready for review November 3, 2026 16:19
@Pigbibi
Pigbibi merged commit a588c73 into main Nov 3, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval. Under Li SiYi's authorization the review bot may apply it after clean review; logged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants