Skip to content

Fix landing icon naming and root favicon path - #6

Merged
Pigbibi merged 1 commit into
mainfrom
feat/site-icons-a-hygiene-r2
Nov 6, 2026
Merged

Fix landing icon naming and root favicon path#6
Pigbibi merged 1 commit into
mainfrom
feat/site-icons-a-hygiene-r2

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Fix the organisation landing icon URLs so browsers can resolve /favicon.ico and all icon/manifest references from the served root. Rename the existing Direction A assets to the approved usage names without changing their bytes, colours or sizes; remove obsolete generated paths and update the landing snippet and regression checks.

Validation: node scripts/build-site-icons.mjs succeeded; npm test passed all 36 tests. The five new icon-path regression tests failed on the unchanged main baseline and passed after the port. git diff --check passed. No workflows or deployment settings changed.

The optional AGENTS.md and site-icons/install.md updates were omitted because their combined diff check reported two placeholder/doc findings. Existing placeholder patterns remain outside this change.

Publication scan (advisory):

  • Checker: publication-check/2.0-advisory (build 83d9d1130377)
  • Total match count: 3; matching lines: 2
  • First 20 masked matches (all returned matches shown):
    • .<PROJECT_ID>/workflows/pages.yml:25: id-token: <REDACTED>
    • AGENTS.md:7: gs:///...and, and use <PROJECT_ID> values in

This was referenced Nov 4, 2026
Open
Open
@Pigbibi

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact current head 5195a4551d9e85e5dff4f32f793fbecc8adf6eab and publish codex-review-state:v1 with code_review.commit_sha equal to this full SHA, status, and has_unresolved_findings. This request is review only; keep the PR Draft. No merge or deployment.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T05:31:30.629776Z 5195a45 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 5195a4551d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi marked this pull request as ready for review November 6, 2026 05:29
@Pigbibi
Pigbibi merged commit 45ce603 into main Nov 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pigbibi @codex