Skip to content

ci(governance): adopt the shared PR governance action - #7

Closed
Pigbibi wants to merge 1 commit into
mainfrom
chore/governance-action-v2
Closed

Pigbibi wants to merge 1 commit into
mainfrom
chore/governance-action-v2

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Qoder agent (Claude) performed the migration and the checks below.

What changed

Replace the inline gate with the organization's shared QuantStrategyLab/.github/pr-governance action pinned to 873eb5afc59a56a394dabe8261e0e2ab5b8f769f (tag v2):

  • .github/workflows/risk-gate.yml is now the rendered shared template.
  • .github/governance/policy.json holds the repo policy (r0_paths, r2_paths, reviewer identity).
  • .github/workflows/pr-review-signal.yml relays fork review events to the trusted run.

Required status contexts are unchanged: risk-gate, ai-review, pr-template, clearing-label.

How verified

  • The rendered gate differs from the shared template only by the repo name and the pinned SHA.
  • actionlint passes on both workflows.
  • Classification stays at least as strict: every .github/** path, manifests, and credential/runtime/strategy paths are R2; prose in docs/ and README is R0; the Codex receipt and clearing-label binding are unchanged.

Replace the inline gate with the pinned v2 composite action, move the
repo policy into .github/governance/policy.json, and relay fork review
events through the permissionless signal workflow. Status check
contexts are unchanged: risk-gate, ai-review, pr-template, clearing-label.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T14:43:08.427457Z a45fab5 PR opened
🔒 Security Review ✅ Completed 2026-11-07T14:43:28.606712Z a45fab5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a45fab5a2e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +6 to +8
"app_id": 1144995,
"user_id": 199175422,
"login": "chatgpt-codex-connector[bot]"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move the reviewer account identifiers into repository variables

This tracked policy publishes the reviewer's actual app ID, user ID and account login, contrary to the public-content boundary in AGENTS.md, which requires account identifiers to come from variables, the environment or protected configuration. Keeping the file outside site/ does not remove those identifiers from public source. Remove these literals and configure the RISK_GATE_REVIEWER_* variables already wired into the evaluation job.

AGENTS.md reference: AGENTS.md:L6-L11

Useful? React with 👍 / 👎.

statuses: write
steps:
- name: Record label head
uses: QuantStrategyLab/.github/pr-governance@873eb5afc59a56a394dabe8261e0e2ab5b8f769f

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the real governance commit identifier out of public source

Both action invocations publish the real governance repository and an exact commit identifier. The repository's content-boundary rule explicitly excludes commit IDs that lead back to real objects, so SHA-pinning this reference does not satisfy that rule. Use an approved public-facing governance distribution, keeping the restricted implementation reference in protected configuration or orchestration rather than publishing it in this workflow.

AGENTS.md reference: AGENTS.md:L12-L14

Useful? React with 👍 / 👎.

@Pigbibi

Pigbibi commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Closed without merging. This repository's AGENTS.md content-boundary rule forbids committing commit identifiers that resolve to real objects, which conflicts with pinning the shared action by full SHA. The shared gate therefore stays out of this repository; it has no required checks and its only published workflow is the Pages deploy.

@Pigbibi Pigbibi closed this Nov 7, 2026
@Pigbibi
Pigbibi deleted the chore/governance-action-v2 branch November 7, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant