Skip to content

Replace GC tracking HashSet with intrusive linked list #7328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Mar 4, 2026
+315 −298
Merged

Replace GC tracking HashSet with intrusive linked list #7328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff3b939
Replace GC tracking HashSet with intrusive linked list
youknowone Mar 3, 2026
6a40f0f
Auto-format: cargo fmt --all
github-actions[bot] Mar 3, 2026
b279716
Fix race condition: create unreachable_refs under read locks
youknowone Mar 4, 2026
b6d5366
Apply code review feedback from PR #7328
youknowone Mar 4, 2026
2c98e8b
Apply suggestions from code review
youknowone Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions crates/common/src/linked_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,15 @@ impl<L: Link> LinkedList<L, L::Target> {
let ptr = L::as_raw(&val);
assert_ne!(self.head, Some(ptr));
unsafe {
// Verify the node is not already in a list (pointers must be clean)
debug_assert!(
L::pointers(ptr).as_ref().get_prev().is_none(),
"push_front: node already has prev pointer (double-insert?)"
);
debug_assert!(
L::pointers(ptr).as_ref().get_next().is_none(),
"push_front: node already has next pointer (double-insert?)"
);
L::pointers(ptr).as_mut().set_next(self.head);
L::pointers(ptr).as_mut().set_prev(None);

Expand Down Expand Up @@ -192,6 +201,20 @@ impl<L: Link> LinkedList<L, L::Target> {
// }
// }

/// Removes the first element from the list and returns it, or None if empty.
pub fn pop_front(&mut self) -> Option<L::Handle> {
let head = self.head?;
unsafe {
self.head = L::pointers(head).as_ref().get_next();
if let Some(new_head) = self.head {
L::pointers(new_head).as_mut().set_prev(None);
}
L::pointers(head).as_mut().set_next(None);
L::pointers(head).as_mut().set_prev(None);
Some(L::from_raw(head))
}
}

/// Returns whether the linked list does not contain any node
pub const fn is_empty(&self) -> bool {
self.head.is_none()
Expand All @@ -212,7 +235,11 @@ impl<L: Link> LinkedList<L, L::Target> {
pub unsafe fn remove(&mut self, node: NonNull<L::Target>) -> Option<L::Handle> {
unsafe {
if let Some(prev) = L::pointers(node).as_ref().get_prev() {
debug_assert_eq!(L::pointers(prev).as_ref().get_next(), Some(node));
debug_assert_eq!(
L::pointers(prev).as_ref().get_next(),
Some(node),
"linked list corruption: prev->next != node (prev={prev:p}, node={node:p})"
);
L::pointers(prev)
.as_mut()
.set_next(L::pointers(node).as_ref().get_next());
Expand All @@ -225,7 +252,11 @@ impl<L: Link> LinkedList<L, L::Target> {
}

if let Some(next) = L::pointers(node).as_ref().get_next() {
debug_assert_eq!(L::pointers(next).as_ref().get_prev(), Some(node));
debug_assert_eq!(
L::pointers(next).as_ref().get_prev(),
Some(node),
"linked list corruption: next->prev != node (next={next:p}, node={node:p})"
);
L::pointers(next)
.as_mut()
.set_prev(L::pointers(node).as_ref().get_prev());
Expand Down
Loading
Loading