Skip to content

Match obsolete comparison diagnostics #9074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
youknowdot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Match obsolete comparison diagnostics #9074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd0c42f
Match obsolete comparison diagnostics with operator tokens
youknowdot Oct 10, 2026
16773b8
Merge main and defer obsolete comparison diagnostics to the parser
youknowdot Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions extra_tests/snippets/builtin_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,58 @@ def _check_flags_error(flags):
compile("from __future__ import barry_as_FLUFL\nx = 1\n", "<test>", "exec")
assert barry_code.co_flags & barry_flag


# Keep Python-visible obsolete-operator diagnostics in Python coverage.
for source, message, locations in (
(
"2 <> 3\n",
"invalid syntax. Maybe you meant '!=' instead of '<>'?",
(1, 3, 1, 5),
),
("<>\n", "invalid syntax", (1, 1, 1, 2)),
("2 <;\n", "invalid syntax", (1, 4, 1, 5)),
("2 <<> 3\n", "invalid syntax", (1, 5, 1, 6)),
("(2 <<> 3)\n", "invalid syntax", (1, 6, 1, 7)),
("# <>\n2 <<> 3\n", "invalid syntax", (2, 5, 2, 6)),
("(\n2 <> 3\n", "'(' was never closed", (1, 1, 1, 0)),
):
try:
compile(source, "<test>", "exec")
except SyntaxError as error:
assert error.msg == message
assert (
error.lineno,
error.offset,
error.end_lineno,
error.end_offset,
) == locations
else:
raise AssertionError("expected an obsolete-operator syntax error")

assert eval(compile("2 <> 3", "<test>", "eval", flags=barry_flag))

for source, locations in (
("<>\n", (1, 1, 1, 3)),
("2 <<> 3\n", (1, 5, 1, 6)),
("(2 <<> 3)\n", (1, 6, 1, 7)),
):
try:
compile(source, "<test>", "exec", flags=barry_flag)
except SyntaxError as error:
assert error.msg == "invalid syntax"
assert (
error.lineno,
error.offset,
error.end_lineno,
error.end_offset,
) == locations
else:
raise AssertionError("expected an invalid operator syntax error")

for flags in (0, barry_flag):
compile("2 << 3", "<test>", "exec", flags=flags)
compile('"<>"', "<test>", "exec", flags=flags)

n = ast.parse('x = "# type: int"\n', type_comments=True)
assert n.body[0].type_comment is None
n = ast.parse("x = '# type: int'\n", type_comments=True)
Expand Down
Loading