Skip to content

Share code construction and comparison controls #9713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
youknowdot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Share code construction and comparison controls #9713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91aa222
Preserve code comparison and hashing callbacks
youknowdot Nov 4, 2026
5777aed
Share code construction and replacement controls
youknowdot Nov 4, 2026
7808947
Use canonical code constructor argument names
codex Nov 6, 2026
b0aecbb
Rely on scope cleanup for redundant explicit drops
codex Nov 6, 2026
886c794
Use shared binding validation for retained code arguments
codex Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions crates/compiler-core/src/bytecode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,26 +969,37 @@ impl CodeUnits {
&self,
resolve: impl Fn(usize, Instruction) -> Instruction,
) -> Vec<u8> {
let len = self.len();
let mut out = Vec::with_capacity(len * 2);
let mut i = 0;
while i < len {
let op = resolve(i, self.read_op(i)).deoptimize();
let arg = self.read_arg(i);
let caches = op.cache_entries();
out.push(u8::from(op));
out.push(u8::from(arg));
let mut out = Vec::with_capacity(self.len() * 2);
for unit in self.original_instructions_with(resolve) {
out.push(u8::from(unit.op));
out.push(u8::from(unit.arg));
// Zero-fill all CACHE entries (counter + cached data)
for _ in 0..caches {
i += 1;
for _ in 0..unit.op.cache_entries() {
out.push(0); // op = Cache = 0
out.push(0); // arg = 0
}
i += 1;
}
out
}

/// Iterate over deoptimized instructions, skipping inline cache data.
/// `resolve` restores instrumentation placeholders before resolving base opcodes.
pub fn original_instructions_with(
&self,
resolve: impl Fn(usize, Instruction) -> Instruction,
) -> impl Iterator<Item = CodeUnit> {
let mut i = 0;
core::iter::from_fn(move || {
if i >= self.len() {
return None;
}
let op = resolve(i, self.read_op(i)).deoptimize();
let unit = CodeUnit::new(op, self.read_arg(i));
i += 1 + op.cache_entries();
Some(unit)
})
}

/// Initialize adaptive warmup counters for all cacheable instructions.
/// Called lazily at RESUME (first execution of a code object).
/// Counters are stored out-of-line to preserve `op = Instruction::Cache`.
Expand Down
Loading
Loading