Repository navigation
Use canonical Rust names for Python bindings - #9730
Merged
youknowone merged 1 commit intoNov 6, 2026
Merged
youknowone merged 1 commit into
youknowone merged 1 commit into
Conversation
Remove unnecessary method, property, argument and attribute name overrides. Rename internal helpers and callers while preserving exported names, signatures, defaults and intentional aliases. Assisted-by: Codex:model-version-unavailable
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
youknowone
approved these changes
Nov 6, 2026
youknowone
marked this pull request as ready for review
November 6, 2026 23:47
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the naming guidance from #9717 and #9719 across the Python 3.15 implementation.
pygetset,pymethod,pyfunction,pyarg,pyattr,pyclassmethod, andpymember.FromArgsalready supports them.Validation
cargo check --locked --offline -p rustpython-vm -p rustpython-stdlib --all-targets --features rustpython-vm/threading,rustpython-stdlib/threading.cargo clippycommand. It reports existing generated-module unused-Result warnings and a generated Unicode dead-code warning; no new naming warnings.Workspace tests were started but stopped during compilation. CAPI tests, Python runtime suites, OpenSSL-specific checks, and the WASM build have not completed locally. This remains a draft pending broader validation and CI.