Checked and updated geopoints cookbook#310
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 38.49% 39.42% +0.92%
==========================================
Files 99 87 -12
Lines 4159 2765 -1394
Branches 10 10
==========================================
- Hits 1601 1090 -511
+ Misses 2557 1674 -883
Partials 1 1 |
mkucharz
requested changes
Oct 30, 2018
| name: geolocation | ||
| description: Intereact with geolocation data object | ||
| runtime: nodejs_v8 | ||
| keywords: |
Member
There was a problem hiding this comment.
Keywords should go to package.json
| ```YAML | ||
| name: geolocation | ||
| description: Intereact with geolocation data object | ||
| runtime: nodejs_v8 |
Member
There was a problem hiding this comment.
Runtime is obsolete now. Please remove it.
|
|
||
| ```YAML | ||
| name: geolocation | ||
| description: Intereact with geolocation data object |
Member
There was a problem hiding this comment.
Description only in package.json
| - name: user | ||
| type: reference | ||
| target: user | ||
| target: user |
Member
There was a problem hiding this comment.
You added there two spaces at the end of the line.
| properties: | ||
| coordinates: | ||
| type: geopoint | ||
| description: latitude, longitude plus optional distance_in_kilometers or distance_in_miles |
Member
There was a problem hiding this comment.
We keep description starting with capital letter.
| { | ||
| "message": Something went wrong!" | ||
| } | ||
| } |
| }) | ||
|
|
||
| return response.json({ message: 'location saved' }, status) | ||
| return response.json(createdGeoPoint, 200) |
Member
There was a problem hiding this comment.
200 is default, no need to add it to response.
mkucharz
requested changes
Oct 30, 2018
| exit_code: 200 | ||
| description: returns a list of Data Objects matching the provided range | ||
| fail: | ||
| exit_code: 404 |
mkucharz
approved these changes
Oct 31, 2018
mattlsp
approved these changes
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went through the cookbook and checked for errors, user should be able to re-product the cookbook outcome