Recover implicit this parameters in GNU3 symbols - #8393
Draft
plafosse wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thisparameter pointing to the structured enclosing typethisfor symbols known to be non-membersRationale
GNU3 symbols generally do not encode whether an ambiguous scoped function is static. The previous implementation only emitted
thiswhen it could prove one existed, which omitted it from ordinary member functions. This changes the fallback to assume an instance method unless the symbol provides evidence that it cannot be one. Ambiguous static members and namespace-scoped functions intentionally follow that fallback.Validation
RelWithDebInfoBinary Ninja standalone application build with UI and plugins