Stop reporting fixed findings as ignored - #109
Merged
Merged
Conversation
A finding the fixer declined, or the confidence gate held back, stayed on the books even after a later round fixed it: it came back in the final IgnoredIssues and was re-sent to reviewers as still declined. Both loops now drop fixed titles from the carried set and the gate ledger. Also trims the repeated declines rationale down to one copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review loop's carried state only grew. A finding the fixer declined, or the gate held back, stayed on the books even after a later round fixed it — so it came back in the final
IgnoredIssues, and reviewers were told it was still declined.Both loops now drop the fixer's
fixedtitles from the carried set and from theGateLedger, at the one place a fix verdict is seen. Removal only ever follows a fix verdict, never an agent going quiet. The commit also cuts the repeated "declines are sent, fixes are not" rationale down to one copy, fixing a stale one that saiddeclinedholds only the last round's refusals.Findings:
docs/research/2026-08-review/review-loop/01-fixed-findings-stay-ignored.md,docs/research/2026-08-review/review-loop/07-declines-rationale-repeated-and-drifted.md