Repository navigation
feat: report on the way with + and confirm arrival in the steward view [MET-A-015] - #293
Conversation
|
Discord notification tracking (managed by GitHub Actions). |
Code coverage
The combined line coverage of changed application files must reach 80%.
Overall application line coverage must reach 80%. |
Anders-Fiedler
left a comment
There was a problem hiding this comment.
looks very good, couldn't find any issues with your code, the only thing is I believe you touch some of the same components in scenarioOverview, so I think a quick merge dev into your branch before merging this into dev would make our lives easier, just to ensure conflicts are resolved before merge not during, good work
46748b1 to
b0cfd71
Compare
Test results
View workflow run · Tested commit: |
b0cfd71 to
a399b2c
Compare
Thanks for the review. I checked by test-merging current dev into the branch, and there are no conflicts. Dev hasn’t changed ScenarioOverview since the branch was made. This PR is stacked, so it merges into the #291 branch rather than dev. When #287 and #291 are merged, it will point at dev, and I’ll rebase it onto dev then, so any conflicts get resolved before the merge and not during it |
cb5d644 to
a370b3b
Compare
Seefagut
left a comment
There was a problem hiding this comment.
Det eneste: noget af din styling findes der allerede noget til i Theme.tsx (fx afrundede hjørner, skriftstørrelser og spacing). Er det et bevidst valg for at få et bestemt look? Ikke en blokerende kommentar, så approved
Anders-Fiedler
left a comment
There was a problem hiding this comment.
since there are no conflicts ill approve :)
Godt fanget, og nej, kun delvist. Den store statustekst og de ekstra afrundede kort er bevidste, fordi de følger skitsen, vi viste stakeholderne |
|



Description
Second of two PRs for #263. The steward sets their status from the steward view during an active scenario:
Choices:
Context
#263, sub-issue of MET-A-015 (#15). Stacked on #291, which is stacked on #287.
How was it verified
Screenshots / Evidence
Cropped to the status area, so no scenario data is shown.
No status
On the way
Arrived
Sketch shown to the stakeholders
Noticed, not fixed
eventcontract (ARRIVED) and the server change are in.Type of change