Add missing translation keys to en.json and fix Slovak (sk) translation - #761
Open
rraddatch wants to merge 1 commit into
Open
Add missing translation keys to en.json and fix Slovak (sk) translation#761rraddatch wants to merge 1 commit into
rraddatch wants to merge 1 commit into
Conversation
- Add missing keys to en.json: on, off, prefDescriptionNone, prefDescFormatOption1, prefDescFormatOption2 - Add Slovak translations for on/off - Fix Slovak: 'citackou obrazovky' -> 'citacom obrazovky' throughout sk.json Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
joedolson
added a commit
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
During work on the Slovak translation (
sk.json), it was discovered that fivetranslation keys referenced in the JavaScript source (
ableplayer.jsviathis.translate()) were missing from the English base fileen.json:on"On"off"Off"prefDescriptionNone"The current video has no audio description in either format."prefDescFormatOption1"alternative described version of video"prefDescFormatOption2"text-based description, announced by screen reader"Because
en.jsonserves as the reference/fallback for all other languages,missing keys here mean any language that also lacks them will silently fall
back to the hardcoded English default in the JS source — with no indication
to translators that a string needs to be translated.
Additionally,
prefIntroDescriptionNoneis present inen.jsonbut is nolonger used in the source code — it appears to have been superseded by
prefDescriptionNone. It has been left in place to avoid breaking anyexternal setups that might reference it, but it should be considered
deprecated.
Changes
translations/en.json— added 5 missing keys with their correct English valuestranslations/sk.json— added Slovak translations foron/off; fixedincorrect instrumental case throughout: čítačkou obrazovky → čítačom obrazovky
(in
prefDescription1andprefDescFormatOption2)Note for maintainers
The five keys added to
en.jsonare currently missing from all other languagefiles as well. It would be great if contributors for each language could add
translations for these keys:
on"On"off"Off"prefDescriptionNone"The current video has no audio description in either format."prefDescFormatOption1"alternative described version of video"prefDescFormatOption2"text-based description, announced by screen reader"