Skip to content

Remove AutoscalingRunnerSet printer columns referencing removed status fields - #4583

Open
Okabe-Junya wants to merge 1 commit into
actions:masterfrom
Okabe-Junya:Okabe-Junya/fix/ars-printer-columns
Open

Remove AutoscalingRunnerSet printer columns referencing removed status fields#4583
Okabe-Junya wants to merge 1 commit into
actions:masterfrom
Okabe-Junya:Okabe-Junya/fix/ars-printer-columns

Conversation

@Okabe-Junya

Copy link
Copy Markdown
Contributor

What

Remove the 5 AutoscalingRunnerSet printer columns that reference status fields missing from the schema, and regenerate the CRDs with make manifests.
The hand-written change is 5 deleted marker lines; the rest is generated.

Before:

$ k get autoscalingrunnersets
NAME              MINIMUM RUNNERS   MAXIMUM RUNNERS   CURRENT RUNNERS   PHASE   PENDING RUNNERS   RUNNING RUNNERS   FINISHED RUNNERS   DELETING RUNNERS
dummy-scale-set   1                 5

After:

$ k get autoscalingrunnersets
NAME              MINIMUM RUNNERS   MAXIMUM RUNNERS   PHASE
dummy-scale-set   1                 5

Why

#4557 removed the runner-count fields from AutoscalingRunnerSetStatus (they are now exposed as controller metrics) and dropped the matching printer columns on EphemeralRunnerSet, but the AutoscalingRunnerSet markers were left behind so the 5 columns above always render empty.

@Okabe-Junya
Okabe-Junya marked this pull request as ready for review July 26, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants