Remove AutoscalingRunnerSet printer columns referencing removed status fields - #4583
Open
Okabe-Junya wants to merge 1 commit into
Open
Remove AutoscalingRunnerSet printer columns referencing removed status fields#4583Okabe-Junya wants to merge 1 commit into
Okabe-Junya wants to merge 1 commit into
Conversation
…oved status fields
Okabe-Junya
marked this pull request as ready for review
July 26, 2026 06:31
Okabe-Junya
requested review from
Steve-Glass,
mumoshu,
nikola-jokic,
rentziass and
toast-gear
as code owners
July 26, 2026 06:31
Draco7587
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the 5
AutoscalingRunnerSetprinter columns that reference status fields missing from the schema, and regenerate the CRDs withmake manifests.The hand-written change is 5 deleted marker lines; the rest is generated.
Before:
After:
Why
#4557 removed the runner-count fields from
AutoscalingRunnerSetStatus(they are now exposed as controller metrics) and dropped the matching printer columns onEphemeralRunnerSet, but theAutoscalingRunnerSetmarkers were left behind so the 5 columns above always render empty.