Skip to content

switch from max_exclusive to max_length (inclusive) - #24

Merged
samuelcolvin merged 3 commits into
mainfrom
max-inclusive
Oct 12, 2022
Merged

switch from max_exclusive to max_length (inclusive)#24
samuelcolvin merged 3 commits into
mainfrom
max-inclusive

Conversation

@samuelcolvin

Copy link
Copy Markdown
Member

fix #23

@adriangb adriangb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #24 (d50aa93) into main (9747ec3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           65        59    -6     
  Branches         5         5           
=========================================
- Hits            65        59    -6     
Impacted Files Coverage Δ
annotated_types/test_cases.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samuelcolvin

Copy link
Copy Markdown
Member Author

Fixed some errors in the readme.

And now the coverage report comes through...3 hours to add a comment.

@samuelcolvin
samuelcolvin merged commit cfe6ddf into main Oct 12, 2022
@samuelcolvin
samuelcolvin deleted the max-inclusive branch October 12, 2022 10:44
adriangb pushed a commit to adriangb/annotated-types that referenced this pull request May 31, 2023
…pes#24)

* switch from max_exclusive to max_length (inclusive)

* tweak docstrings

* fix readme and another case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rethink max_exclusive, convert to max_inclusive?

4 participants