Fix SnowflakeSqlApiOperator polling to avoid needless sleeps - #69450
Merged
amoghrajesh merged 2 commits intoJul 6, 2026
Conversation
pierrejeambrun
approved these changes
Jul 6, 2026
phanikumv
reviewed
Jul 6, 2026
phanikumv
reviewed
Jul 6, 2026
Lee-W
approved these changes
Jul 6, 2026
1 task
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
What
SnowflakeSqlApiOperator.poll_on_queries()polls the status of every submitted SQL API statement handle in a loop and waitspoll_intervalseconds between checks. It exists to avoid hammering the Snowflake SQL API while a query is still running.Current behaviour
The
time.sleep(self.poll_interval)call sits inside the per-handleforloop, so it fires after every handle is checked, regardless of whether that handle (or any other) is still running. For a batch of N statement handles, a single call topoll_on_queries()can sleep for up toN * poll_intervalseconds even when every handle already resolved tosuccessorerroron this pass. This adds pointless latency: a batch that just finished still waits before the operator can move on and report the result (or raise on failure).Proposed change
Move the sleep out of the per-handle loop to run at most once per call to
poll_on_queries(), and only when at least one handle is stillrunningafter checking all of them. A cycle where everything already resolved (all succeeded, or one failed) now returns immediately instead of sleeping first.{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.