[MINSTALL-160] Generated POM is not installed if original POM exists - #36
Merged
Conversation
When using `generatePom=true` with install-file Mojo, it will despite this copy existing POM if it is found embedded in JAR (and if it was built with Maven, it will find it). The generatePom should reuse POM values embedded from JAR but should generate (and install) new "empty POM" instead.
|
Works for me. 👍 |
michael-o
approved these changes
Jul 18, 2022
|
Resolve #326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
generatePom=truewith install-file Mojo, it will despitethis copy existing POM if it is found embedded in JAR (and if it
was built with Maven, it will find it).
The generatePom should reuse POM values embedded from JAR
but should generate (and install) new "empty POM" instead.
https://issues.apache.org/jira/browse/MINSTALL-160