Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Install using npm installed during installation of script dependencies #23322

Merged
sadick254 merged 3 commits into from
Dec 3, 2021
+3 −28
Merged

Install using npm installed during installation of script dependencies #23322

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36562ea
Install using npm installed during installation of script dependencies
sadick254 Dec 3, 2021
22c3e44
We don't need to verify npm version
sadick254 Dec 3, 2021
309ecff
Use correct npm bin name depending on the OS
sadick254 Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use correct npm bin name depending on the OS
  • Loading branch information
@sadick254
sadick254 committed Dec 3, 2021
commit 309ecff84d2635bb4d615e4867ed967c9a8b8a60
3 changes: 2 additions & 1 deletion script/lib/install-script-dependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ process.env.ELECTRON_CUSTOM_VERSION = CONFIG.appMetadata.electronVersion;

module.exports = function(ci) {
console.log('Installing script dependencies');
const npmBinName = process.platform === 'win32' ? 'npm.cmd' : 'npm';
childProcess.execFileSync(
'npm',
npmBinName,
['--loglevel=error', ci ? 'ci' : 'install'],
{ env: process.env, cwd: CONFIG.scriptRootPath }
);
Expand Down