Add EE.getReleaseTarget() method - #5358
Merged
Merged
Conversation
bjhargrave
requested changes
Aug 24, 2022
bjhargrave
left a comment
Member
There was a problem hiding this comment.
Also, EETest needs updating to test the new release target method.
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Contributor
Author
Test adjusted as well. |
laeubi
requested review from
bjhargrave and
timothyjward
and removed request for
bjhargrave
August 24, 2022 18:12
bjhargrave
requested changes
Aug 24, 2022
bjhargrave
left a comment
Member
There was a problem hiding this comment.
We should use assertj tests.
Co-authored-by: BJ Hargrave <bj@hargrave.dev> Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Contributor
Author
Done. |
laeubi
requested review from
bjhargrave and
timothyjward
and removed request for
bjhargrave and
timothyjward
August 25, 2022 17:37
bjhargrave
approved these changes
Aug 25, 2022
Contributor
Author
|
@bjhargrave @timothyjward thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@timothyjward as suggested in #5357 (comment)