Extract code to automatically derive data from maven-project - #6362
Conversation
f330ad1 to
f3cc8d4
Compare
|
The build failure looks like my change in the shared lib is not picked up by the maven build. |
|
@bjhargrave any hint / idea what could be wrong? |
I don't know. But this PR seems to be poorly designed from an object oriented perspective. There are 2 things unrelated: reading the configuration from the pom/bnd file and setting some defaults, for bundle building, if they have not been set. I don't see why BndConfiguration should have an instance method for setting defaults since default settings never needed the configuration. That seems a poor place to put default settings for the bnd maven plugin and conflates two things. |
f3cc8d4 to
aa3c4e2
Compare
I think my naming was not really good here, I have now adjusted it to better reflect the meaning. It is actually not any defaults but apply some implicit configuration (and just converted to bnd instructions). Still of course it could also be extracted in a separate class, the main point is that it should not be mangled with the Mojo so it can be used in other context as well. Sadly this would not resolve the issue that for some reason the invoker tests seem not to "see" the bnd-build jar file with the shared code but some outdated variant :-\ |
|
The problem seems to be that the bnd-baseline-maven-plugin has no dependency to biz.aQute.bnd.maven in its pom.xml. Therefore, the latest biz.aQute.bnd.maven it is not copied to the testing repo. With the wonderful maven logic, it will then likely get it from some random repository, which happens to be the previous version ... Other bnd plugins might have the same problem although the bnd-maven-plugin seems ok. However, I'd like to see @bjhargrave 's concerns addressed. |
aa3c4e2 to
11e675e
Compare
11e675e to
f081c06
Compare
|
Build seems running fine now! 👍 |
|
I have extracted now the adjustments to the poms in a separate PR here: once it is merged I will rebase/adjust this change so we only have the changes related to the topic itself. |
7f9d03b to
a5c618e
Compare
a5c618e to
e2e410b
Compare
e2e410b to
bd8c51b
Compare
bd8c51b to
c9db60b
Compare
Currently if one loads the configuration with aQute.bnd.maven.lib.configuration.BndConfiguration then only the configuration itself is loaded, but actually some implicit configuration later apply (e.g. from the maven project configuration) that is currently only performed by the AbstractBndMavenPlugin. This extracts this logic from the AbstractBndMavenPlugin into the BndConfiguration class for the following benefits: - making the AbstractBndMavenPlugin maintain less code in the execute method - allow other users of BndConfiguration to easily inherit common defaults - separation of concerns, easier to debug and understand Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
c9db60b to
f439ce8
Compare
|
Build is green now! |
|
Can I merge this? |
I have no objection. |
Currently if one loads the configuration with
aQute.bnd.maven.lib.configuration.BndConfigurationthen only theconfiguration itself is loaded, but actually some implicit configuration later apply (e.g. from the maven project configuration)
that is currently only performed by the
AbstractBndMavenPlugin.This extracts this logic from the
AbstractBndMavenPlugininto theBndConfigurationclass for the following benefits:AbstractBndMavenPluginmaintain less code in the executemethod
BndConfigurationto easily inherit commondefaults