Repository navigation
Use explicit extensions in generated ESM index imports - #2087
Draft
Victor-Su-Ortiz wants to merge 1 commit into
Draft
Victor-Su-Ortiz wants to merge 1 commit into
Victor-Su-Ortiz wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2010. Generate explicit
.jsimports in the async-es index, consistent with the individual modules. Add a build regression that checks relative specifiers and exercises the index and a generated alias in native ESM; keep the test compatible with Node 18.Verification
npm test: lint and 703 tests passed.git diff --checkpassed.Limitations
The complete release build was not validated successfully in this macOS checkout. GNU Make 3.81 cannot expand the existing alias target rule; the ESM verification reproduced its source/alias copy actions locally.
make test-buildalso encounters the existing compiler's yargs argv incompatibility. Generated temporary build debris was preserved outside the lint scan before rerunning npm test. Actual browser automation was not run; the regression uses strict native ESM resolution.AI assistance
Implementation and tests generated with OpenCode
opencode/space-bunny-free(Space Bunny). Codex independently reviewed and ran the checks and requested the Node 18 compatibility correction. No human code review has occurred. Submitted as a draft for maintainer review.