docs(client-only): add line examples and wire ExampleTabs#10642
Open
ossamanahle wants to merge 1 commit intochakra-ui:mainfrom
Open
docs(client-only): add line examples and wire ExampleTabs#10642ossamanahle wants to merge 1 commit intochakra-ui:mainfrom
ossamanahle wants to merge 1 commit intochakra-ui:mainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Hi! Just checking in to see if this PR needs any updates from my side. Happy to make changes if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add live
ClientOnlydocs examples and wire them withExampleTabs.Current behavior (updates)
The
ClientOnlydocs page mostly used static code snippets and did not show runnableexamples via
ExampleTabs.🚀 New behavior
Added three runnable examples in
apps/compositions/src/examples:client-only-basic.tsxclient-only-with-fallback.tsxclient-only-render-prop.tsxUpdated
apps/www/content/docs/components/client-only.mdxto render these exampleswith:
<ExampleTabs name="client-only-basic" /><ExampleTabs name="client-only-with-fallback" /><ExampleTabs name="client-only-render-prop" />💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Scope is docs/examples only. No new dependencies were added.