Skip to content

Anchor link added issue #1044#1066

Merged
lpatmo merged 2 commits into
codebuddies:stagingfrom
akarshsingh9:staging
Oct 31, 2018
Merged

Anchor link added issue #1044#1066
lpatmo merged 2 commits into
codebuddies:stagingfrom
akarshsingh9:staging

Conversation

@akarshsingh9

@akarshsingh9 akarshsingh9 commented Oct 29, 2018

Copy link
Copy Markdown
Contributor

Fixes # 1044

Added an anchor tag to the <h 1>Where should I share a commercial post on Slack?</h 1> on codebuddies.org/slack page, so that users can type in https://codebuddies.org/slack#commercial and land directly on that section of the page.

@lpatmo lpatmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One change: could you turn the header into #333 instead of the blue it currently is? I believe the relevant file to edit is _slack.scss. Let me know if you have questions! Thanks.

@akarshsingh9

Copy link
Copy Markdown
Contributor Author

Please review the latest commit 9cbe1ea

@lpatmo

lpatmo commented Oct 31, 2018

Copy link
Copy Markdown
Member

Thanks @akarshsingh9!

@lpatmo lpatmo merged commit 6d551dc into codebuddies:staging Oct 31, 2018
@lpatmo lpatmo added [state] closed the issue is now closed, see comments for more information and removed Waiting For Review labels Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[state] closed the issue is now closed, see comments for more information

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants