Refactor about page v2#762
Merged
distalx merged 37 commits intoJan 13, 2018
Merged
Conversation
Refactor about page
@railsstudent I added a short placeholder-ish description for you, but please feel free to edit!
…t/codebuddies into railsstudent-refactor-about-page-v2
distalx
approved these changes
Jan 13, 2018
distalx
left a comment
Member
There was a problem hiding this comment.
Thanks, @railsstudent for fixing that. 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #760
Fix interpolation operators used in about.html. In html file, they should be {{ value }}, ${ value } is ES6 syntax
Currently, the github, twitter and blog links are not interpolated and using static texts socials.github, socials.twitter and social.blog.