Skip to content

Issue 988#992

Merged
lpatmo merged 3 commits into
codebuddies:stagingfrom
tekamunatekalng:issue-988
Oct 3, 2018
Merged

Issue 988#992
lpatmo merged 3 commits into
codebuddies:stagingfrom
tekamunatekalng:issue-988

Conversation

@tekamunatekalng

Copy link
Copy Markdown
Contributor

Fixes issue #988

  • Removed I am working on tab and took 100% width for the Today I learned tab
  • also made limit 10 for recent learnings

@lpatmo

lpatmo commented Oct 3, 2018

Copy link
Copy Markdown
Member

@LeomarAmiel Perfect, thanks. Do you mind making one more small commit?

i18n/en.i18n.json
25:  "today_i_learned": "Today I learned ...",

Could you change this value to Today I Learned?

@tekamunatekalng

Copy link
Copy Markdown
Contributor Author

@lpatmo capitalized Learned ✌🏽

@lpatmo

lpatmo commented Oct 3, 2018

Copy link
Copy Markdown
Member

@LeomarAmiel Thank you!

@lpatmo lpatmo merged commit 75ce39f into codebuddies:staging Oct 3, 2018
@lpatmo lpatmo added [state] closed the issue is now closed, see comments for more information and removed Waiting For Review labels Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[state] closed the issue is now closed, see comments for more information

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants