Skip to content

fix(coderd/rbac): make workspace ACL disabled flag atomic#21799

Merged
geokat merged 1 commit intomainfrom
geokat/internal-1317-data-race-on-workspace-acl-disabled-in-tests
Jan 30, 2026
Merged

fix(coderd/rbac): make workspace ACL disabled flag atomic#21799
geokat merged 1 commit intomainfrom
geokat/internal-1317-data-race-on-workspace-acl-disabled-in-tests

Conversation

@geokat
Copy link
Contributor

@geokat geokat commented Jan 30, 2026

The flag is a package-global that was only meant to be set once on startup. This was a bad assumption since the lack of sync caused test flakes.

Related to:
coder/internal#1317
coder/internal#1318

@geokat geokat changed the title fix(coderd/rback): make workspace ACL disabled flag atomic fix(coderd/rbac): make workspace ACL disabled flag atomic Jan 30, 2026
The flag is a package-global that was only meant to be set once on startup.
This was a bad assumption since the lack of sync caused test flakes.

Related to:
coder/internal#1317
coder/internal#1318
@geokat geokat force-pushed the geokat/internal-1317-data-race-on-workspace-acl-disabled-in-tests branch from 5096297 to fc16a9e Compare January 30, 2026 18:41
@geokat geokat marked this pull request as ready for review January 30, 2026 18:56
@geokat geokat requested a review from Emyrk as a code owner January 30, 2026 18:56
@geokat geokat merged commit c60f802 into main Jan 30, 2026
29 checks passed
@geokat geokat deleted the geokat/internal-1317-data-race-on-workspace-acl-disabled-in-tests branch January 30, 2026 19:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants