feat: convert soft_limit to limit (cherry-pick/v2.28)#22208
Merged
f0ssel merged 3 commits intorelease/2.28from Feb 23, 2026
Merged
feat: convert soft_limit to limit (cherry-pick/v2.28)#22208f0ssel merged 3 commits intorelease/2.28from
soft_limit to limit (cherry-pick/v2.28)#22208f0ssel merged 3 commits intorelease/2.28from
Conversation
soft_limit to limit (cherry-pick/v2.28)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77082adca5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ): Pick<React.ComponentProps<typeof Link>, "href" | "children" | "target"> => { | ||
| if (message === LicenseManagedAgentLimitExceededWarningText) { | ||
| return { | ||
| href: docs("/ai-coder/ai-governance"), |
There was a problem hiding this comment.
Point managed-agent warning CTA to a valid docs page
The new managed-agent warning link uses docs("/ai-coder/ai-governance"), but this route does not exist in the current docs tree (the AI Coder section in docs/manifest.json has no ai-governance entry). In production this sends users to a dead docs URL from the dashboard banner, so they can’t follow the intended remediation flow when this warning appears.
Useful? React with 👍 / 👎.
5 tasks
In relation to [`internal#1281`](coder/internal#1281) Managed agent workspace build limits are now advisory only. Breaching the limit no longer blocks workspace creation — it only surfaces a warning. - Removed hard-limit enforcement in `checkAIBuildUsage` so AI task builds are always permitted regardless of managed agent count. - Updated the license warning to remove "Further managed agent builds will be blocked." verbiage. - Updated tests to assert builds succeed beyond the limit instead of failing. - Removed the "Limit" display from the `ManagedAgentsConsumption` progress bar — the bar is now relative to the included allowance (soft limit) only, and turns orange when usage exceeds it. Bonus: - De-MUI'd `LicenseBannerView` — replaced Emotion CSS and MUI `Link` with Tailwind classes. - Added `highlight-orange` color token to the Tailwind theme. (cherry picked from commit 2038997)
In relation to [`internal#1281`](coder/internal#1281) Remove the `soft_limit` field from the `Feature` type and simplify license limit handling. This change: - Removes the `soft_limit` field from the API and SDK - Uses the soft limit value as the single `limit` value in the UI and API - Simplifies warning logic to only show warnings when the limit is exceeded - Updates tests to reflect the new behavior - Updates the UI to use the single limit value for display (cherry picked from commit 051ed34)
#21998 accidentally allowed `Managed Agents` usages whilst being on an `Enterprise` license. This was incorrect, it should work as the following (same as prior to #21998). | Scenario | Before your PRs | After your PRs (bug) | After this fix | |---|---|---|---| | Unlicensed (AGPL) | Permitted | Permitted | Permitted | | Licensed, no entitlement | **Blocked** | Permitted | **Blocked** | | Licensed, explicitly disabled (limit=0) | **Blocked** | Permitted | **Blocked** | | Licensed, entitled, under limit | Permitted | Permitted | Permitted | | Licensed, entitled, over limit | Blocked | Permitted (advisory) | Permitted (advisory) | | Any license, stop/delete | Permitted | Permitted | Permitted | | Any license, non-AI build | Permitted | Permitted | Permitted |
146b25b to
623a5e4
Compare
f0ssel
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
internal#1281Cherry picks two pull-requests in
release/2.28.soft_limittolimit#22048Managed AgentsonEnterprise#22210