Performance improvements (1/3) to example-advanced.nginx.conf - #1709
Merged
2 commits merged intoDec 9, 2024
Merged
Conversation
Returns 404 when using exact match without slash
|
@nisbet-hubbard thanks a lot for your contribution! We tested your changes on our staging environment and everything looks good. It'll be part of next release. 😊👍🏻 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of three projected PRs meant to close #1704. The patch is separated out to make testing easier. The second and third parts will cover security headers and load balancing (between workers/cores) respectively.
This patch consists of standard optimisations to nginx configuration and regex:
returninstead ofrewriteto avoid interpreting^(.*)$and creating additional variable. https://blog.nginx.org/blog/creating-nginx-rewrite-rules\/to/as nginx doesn’t use forward slash as regex delimiter. https://www.f5.com/company/blog/nginx/regular-expression-tester-nginx.*$as.*and$cancel each other out.=) or prefix (^~) match instead of regex match whenever it’s possible to preserve the same semantics, as both terminate the search immediately on match before any regex gets searched.