Skip to content

Add Skip Link - #1774

Merged
yflory merged 18 commits into
stagingfrom
skip-link
Mar 13, 2025
Merged

Add Skip Link#1774
yflory merged 18 commits into
stagingfrom
skip-link

Conversation

@dariiing

@dariiing dariiing commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

This PR introduces a skip link to improve accessibility, allowing users to quickly navigate to the main content.
Fixes #1202

@dariiing dariiing added Accessibility Make software available to everyone Screen Reader Issues regarding screen reader usage Keyboard navigation labels Feb 5, 2025
@dariiing dariiing added this to the Spring Release (2025.3.0) milestone Feb 5, 2025
@dariiing dariiing self-assigned this Feb 5, 2025
@dariiing
dariiing changed the base branch from main to staging February 5, 2025 15:11
@davidbenque

davidbenque commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

In Kanban sometimes my focus is on the first column's edit button by default instead of before the skip link

@davidbenque

Copy link
Copy Markdown
Contributor

In Rich Text pressing enter when the skip link is in focus doesn't produce any result

@dariiing
dariiing marked this pull request as ready for review March 12, 2025 12:43
@dariiing dariiing added the Ready to Review This PR is ready to be checked by another team member label Mar 12, 2025
@yflory yflory added Ready to Test This PR is ready to be tested and removed Ready to Review This PR is ready to be checked by another team member labels Mar 12, 2025
@davidbenque davidbenque removed Accessibility Make software available to everyone Keyboard navigation Screen Reader Issues regarding screen reader usage labels Mar 12, 2025
@yflory
yflory merged commit 12b3337 into staging Mar 13, 2025
@zuzanna-maria

Copy link
Copy Markdown
Contributor

A description of some behaviours I found which may or may not be desired (Firefox desktop):

  • In Kanban, skip link skips tag button + tag/drag toggles as well as generic main toolbar
  • In Pad + Presentation, can’t escape editor with ESC in order to tab through interface - have to click outside of the editor manually; editor toolbars skipped
  • In diagram - focus gets ‘lost’ after navigating through right hand side panel; skip link doesn’t appear unless interface manually clicked first outside of the editor
  • In document - OO embedded file menu/toolbar inaccessible to keyboard
  • For multiple apps, the ‘do you want to store’ modal is the first thing that is accessed through tabbing, not the skip link

@davidbenque

Copy link
Copy Markdown
Contributor

Many thanks @zuzanna-maria for catching these. I think the majority are known issues which could not be resolved for this v1 of the skip link. Pinging @dariiing anyway as the last one about storing dialog may not be known.

@dariiing
dariiing deleted the skip-link branch March 25, 2025 08:55
@davidbenque davidbenque removed the Ready to Test This PR is ready to be tested label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants