Show error message when x2t conversion fails in OO editor - #1890
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #1888 by updating the error messaging when x2t conversion fails in the OnlyOffice editor. The changes include replacing generic UI.warn calls with UI.alert calls that display a more descriptive message, and adding a new message (Messages.oo_couldNotConvertDocument) to provide clearer user feedback.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| www/common/onlyoffice/inner.js | Replaces calls to UI.warn(Messages.error) with UI.alert(Messages.oo_couldNotConvertDocument) to improve error communication during conversion failures. |
| customize.dist/messages.js | Introduces a new error message string to be used when document conversion fails. |
Comments suppressed due to low confidence (3)
www/common/onlyoffice/inner.js:1601
- Replacing UI.warn with UI.alert improves user feedback. Please verify that passing the callback 'cb' to UI.alert aligns with its intended behavior.
UI.alert(Messages.oo_couldNotConvertDocument, cb);
www/common/onlyoffice/inner.js:2188
- Ensure that using UI.alert without a callback in this branch still provides the desired user experience for error reporting.
UI.alert(Messages.oo_couldNotConvertDocument);
customize.dist/messages.js:143
- [nitpick] The new error message is descriptive; please confirm that the provided text clearly informs users about the conversion failure and any potential format limitations.
Messages.oo_couldNotConvertDocument = "The conversion of the document failed. Note that MS file formats are currently more stable.";
yflory
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1888