Repository navigation
Initialize non-zero spec defaults on generated Rust types - #38
Merged
Merged
Conversation
Structs with a non-zero default get a manual Default impl so User::default() and struct update syntax pick up spec values. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defaultimpl for datasource and view structs that have a non-zero spec default, including nested structs those impls construct.Some(false)on nullable fields) and language zeros elsewhere (String::new(),UNIX_EPOCH).String.Test plan
npm testin generators-rustUser::default()and..Default::default()pick up non-zero spec valuesMade with Cursor