Conversation
Require DigestAlgorithm SEQUENCE element count (OID + optional NULL) so asn1.validate cannot ignore interior padding that bypasses CVE-2026-33894. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @Krysthyan I can get behind this solution instead of the one I've made, since it's simpler and does not introduce the potential overhead of adding captureAsn1 to check the same thing. Have you run the rest of the suites just in case they also pass? @davidlehn can you check this? The CVE is blocking several pipelines as much as I can see in the mentions of #1149 I will close my PR in favor of this one. |
|
Would it be possible to review this PR? We have a vulnerability on our application due to it. |
This was referenced Oct 2, 2026
6 tasks
5 tasks
Brad-Edwards
added a commit
to Brad-Edwards/shifter
that referenced
this pull request
Oct 2, 2026
osv-scanner flags node-forge@1.4.0 (CVE-2026-85393 / GHSA-86w9-cpqp-85rv, an incomplete fix for CVE-2026-33894) in the Identity Platform blocking function's dependency tree. node-forge is the latest published version, the advisory has no fixed release (upstream digitalbazaar/forge#1152 is unmerged), and the parent gcip-cloud-functions@0.2.1 still requires node-forge@^1.3.1, so there is no upgrade path. node-forge is pulled in only transitively and is never imported: the SDK runtime (gcip-cloud-functions/lib/**) contains no require('node-forge'), and the inbound Identity Platform event JWT is verified via jsonwebtoken (Node crypto). Rather than ship dormant vulnerable crypto, replace the unused implementation with a documented local no-op: declare node-forge as a direct file: dependency on vendor/node-forge (version 1.4.1, just past the affected <=1.4.0 range and still satisfying the SDK's ^1.3.1), so npm installs only this local copy and no vulnerable node-forge enters the tree or the committed lockfile. The function's own tests still pass, confirming node-forge is not exercised. Remove vendor/node-forge and this dependency once upstream ships a fixed release.
fpusset
approved these changes
Oct 2, 2026
4 tasks
ogabasseyy
added a commit
to ogabasseyy/Baci
that referenced
this pull request
Oct 2, 2026
hono override 4.13.5 -> 4.13.7 (GHSA-hxh3-vqpv-xpqv boundary XSS). node-forge has no fixed release, so backport upstream digitalbazaar/forge#1152 as a pnpm patch (byte-identical to upstream post-image) with a patch-integrity test; dev-tooling-only reachability via @expo/cli.
8 tasks done
4 of 7 tasks
4 tasks done
6 of 7 tasks
4 tasks done
Open
4 tasks
7 of 8 tasks
5 tasks
4 tasks done
sf-sahil-jassal
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
obj.value.length === 2on the outerDigestInfoSEQUENCE.asn1.validatestill ignores extra children inside the nestedDigestAlgorithmSEQUENCE, so attackers can stuff ~314 garbage bytes there and forge signatures for low public exponent keys (e.g.e=3).DigestAlgorithmSEQUENCE to contain only the OID plus an optional NULL (same pattern as the outer length check).Test plan
DigestAlgorithmchildren[OID, NULL, garbage]verified astruebefore the change; throws invalid DigestInfo after.should check nested DigestAlgorithm element countintests/unit/rsa.js.npx mocha tests/unit/rsa.js— 101 passing, 4 pending.Related: #1151 (same issue; this PR uses
obj.value[0].value.lengthinstead of addingcaptureAsn1).