Skip to content

Fix template minor issues#4281

Open
Chadys wants to merge 3 commits intodjango-oscar:masterfrom
Chadys:fix_template_minor_issues
Open

Fix template minor issues#4281
Chadys wants to merge 3 commits intodjango-oscar:masterfrom
Chadys:fix_template_minor_issues

Conversation

@Chadys
Copy link
Contributor

@Chadys Chadys commented Apr 22, 2024

3 little changes (one for each commit):

  • in checkout template, use line object everywhere
  • add consistency to review file location and detail url retrieval
  • make every communication template inherit from corresponding base template file. Some of them where missing the extends.

However for that last one, there is the issue of having Thanks for your interest, The {{ site }} Team in some templates, which is redundant with the base template signature.
Affected files are:

  • oscar/templates/oscar/communication/emails/commtype_product_alert_confirmation_body.html
  • oscar/templates/oscar/communication/emails/commtype_product_alert_confirmation_body.txt
  • oscar/templates/oscar/communication/emails/commtype_product_alert_body.txt
    (Note the inconsistency between product_alert_body text and html content since the aforementioned text is only present in one of them)
    I didn't want to edit translated texts without first asking how this is done for the project.

@Chadys Chadys force-pushed the fix_template_minor_issues branch from 0423e91 to 89d157e Compare April 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant