fix: prevent checkout button display in basket#4289
Open
Chadys wants to merge 1 commit intodjango-oscar:masterfrom
Open
fix: prevent checkout button display in basket#4289Chadys wants to merge 1 commit intodjango-oscar:masterfrom
Chadys wants to merge 1 commit intodjango-oscar:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4289 +/- ##
==========================================
- Coverage 88.28% 88.27% -0.01%
==========================================
Files 293 293
Lines 16046 15911 -135
==========================================
- Hits 14166 14046 -120
+ Misses 1880 1865 -15
🚀 New features to boost your workflow:
|
8140884 to
a33ee6c
Compare
samar-hassan
requested changes
Jun 14, 2024
Member
samar-hassan
left a comment
There was a problem hiding this comment.
Thanks for all your contributions @Chadys. Please see if you can outline the steps to reproduce it. I tested this and found out include_buttons should be set to False in basket.views.SavedView. Kindly add it there as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some actions make the basket notification message display the "Checkout now" while we are on the basket page. This is a fix