Open
Conversation
Contributor
Author
Contributor
|
I think this is really country specific is it not? In the Netherlands, yes we want this order, but for other countries it may be different. what could be useful is if we add settings that dictate the order of fields on the forms. something like OSCAR_CHECKOUT_SHIPPING_ADDRESS_FORM_FIELD_ORDER = [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed everywhere the ordering of fields in an address.
Maybe changing line4 to city name in model?
Maybe in the settings we can specify one field lists and use it everywhere? Maybe something like this settings:
OSCAR_REQUIRED_ADDRESS_FIELDS = (
"first_name",
"last_name",
"line1",
"postcode",
"line4",
"country",
)