Fix for duplicate key violation for exposed ports#1392
Conversation
|
The test failures appear to be unrelated and on mainline. |
|
@ctoestreich please sync with the latest master to fix the CI |
| public Map<String, Object> toPrimitive() { | ||
| return Stream.of(exposedPorts).collect(Collectors.toMap( | ||
| return Stream.of(exposedPorts) | ||
| .distinct() |
There was a problem hiding this comment.
instead of distinct(), we can use a merge strategy (3rd argument of toMap) that does not throw, but uses the previously set value
|
@ctoestreich could you please allow maintainers to make edits? (there is a checkbox in PR's settings) |
|
@bsideup looking for checkbox to allow don’t see it atm. |
|
Nope not on screen and not avail after close or reopen. |
|
@ctoestreich you should find it on PR's right section: |
|
@bsideup nope not there for me. Sorry on the iPad and the copy paste photos doesn’t want to work with github. https://share.icloud.com/photos/0lO0qcXfNzuLypHg8b_6GnGdQ |
|
@ctoestreich ok, this is weird :D Could you please apply the change then? (3rd argument of |
|
Superseeded by #1406 |
Found an issue where ports are being added duplicately to the map and causing an exception. I am still investigating how this situation arose, but this code will prevent the exception.