Repository navigation
test(streaming): cover JSON converter read contracts - #10884
Merged
ReubenBond merged 1 commit intoAug 28, 2026
Merged
Conversation
11 tasks
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Lite
Findings: None
What changed in this PR
Adds deterministic contract tests to increase branch/line coverage for Orleans streaming JSON deserialization, focusing on EventSequenceTokenJsonConverter.Read and AsyncStreamConverter.Read behavior in both valid and failure-path inputs.
Changes:
- Introduces BVT theory/fact tests validating discriminator handling and concrete-type selection for
StreamSequenceTokendeserialization. - Adds tests for
IAsyncStream<T>JSON read paths covering identity reconstruction, malformed payloads, missing/incompatible keyed providers, and provider activation failures. - Verifies deserialization does not invoke stream provider lifecycle/operation APIs.
| File | Description |
|---|---|
| test/Orleans.Streaming.Tests/JsonConverters/StreamingJsonConverterTests.cs | Adds targeted BVT coverage for streaming JSON converter read contracts, including malformed payload and DI/provider resolution paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Code coverage78.61% line coverage - 99,529 / 126,605 lines Coverage details
|
This was referenced Aug 29, 2026
Merged
This was referenced Sep 7, 2026
This was referenced Sep 9, 2026
Closed
Closed
This was referenced Sep 16, 2026
Open
Merged
Merged
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The highest-risk streaming JSON read paths had substantial uncovered branches around discriminator handling, malformed shapes, keyed-provider resolution, and stream identity reconstruction.
Solution
EventSequenceTokenJsonConverter.ReadandAsyncStreamConverter.Read.Coverage impact
AsyncStreamConverter.ReadEventSequenceTokenJsonConverter.ReadThis is the first mergeable slice of the broader streaming and broadcast coverage work.
Part of #10862
Microsoft Reviewers: Open in CodeFlow