fix!: add uniqueItems: true in class-methods-use-this#20306
Closed
lumirlumir wants to merge 8 commits into
Closed
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…nt/eslint into fix-add-uniqueitems-true-in
Tanujkanti4441
requested changes
Nov 10, 2025
Co-authored-by: Tanuj Kanti <86398394+Tanujkanti4441@users.noreply.github.com>
Member
|
@lumirlumir the scope of breaking changes for ESLint v10.0.0 is frozen. Can you please open an issue about these changes (adding |
Member
|
I'm going to close this PR so that we don't accidentally merge it as it isn't planned for ESLint v10. You can open a new one when we start preparing ESLint v11. |
This was referenced Nov 15, 2025
This was referenced Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR is a follow-up to #20155.
In this PR, I've added
uniqueItems: trueto the schema for theexceptMethodsoption of theclass-methods-use-thisrule.Given the rule's description and implementation, preventing duplicate exception names seems valid and safe.
Currently, adding the following test case to the
validtests does not produce any errors:Is there anything you'd like reviewers to focus on?
N/A