test: add unit tests for IdGenerator#20775
Merged
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
DMartens
reviewed
Apr 19, 2026
| }); | ||
|
|
||
| it("should cast prefix to string", () => { | ||
| const generator1 = new IdGenerator(123); |
Contributor
There was a problem hiding this comment.
Can you please remove the number prefix here and the next test case (generator1 -> generator) as there is only a single generator per test case.
DMartens
reviewed
Apr 19, 2026
|
|
||
| it("should wrap around to 1 when the counter overflows", () => { | ||
| const generator = new IdGenerator("s"); | ||
| generator.n = 2147483647; |
Contributor
There was a problem hiding this comment.
This test case would be easier to follow when the number is assigned to a variable and calculated: const INT32_MAX = (2 ** 31) - 1
DMartens
reviewed
Apr 19, 2026
Contributor
|
Changes LGTM, thanks. |
DMartens
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: Add unit tests for
IdGeneratorWhat changes did you make? (Give an overview)
This PR introduces unit tests for the
IdGeneratorclass located atlib/linter/code-path-analysis/id-generator.js, which was previously lacking direct test coverage.Specifically, it tests:
next()function for sequentially tracking identifier suffix generation.1.Is there anything you'd like reviewers to focus on?
The tests ensure the correct wrap-around when encountering
2147483647(the max 32-bit integer), allowing us to safely maintain overflow testing logic.(Note: we originally attempted to remove the
c8 ignorepragmas inIdGenerator, but the source edits were pulled from this scope to strictly contribute testing logic).