Repository navigation
TM-195: Spanish text gaps from TM-194 review - #123
Merged
Merged
Conversation
Owner
Author
|
Review: approved. Every news key in messages.md has Spanish text, auth wording matches auth.* keys, typecheck and tests pass. |
Owner
Author
|
QA: passed - synced with develop, typecheck and full suite green. All 42 news rows of messages.md match spanishStrings.ts text for text and appear in ui.md, stage loading and load-error keys are used by StageHost, server and shared auth messages now match the auth.* wording (voseo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the 18 news texts missing from spanishStrings.ts, keys for the StageHost loading and error messages, the missing rows of ui.md 13.9, and aligns the shared auth validation and server auth messages with the ui.md auth.* wording (voseo). Test: run the web, server and shared suites; compare news keys of messages.md with spanishStrings.ts; trigger a bad login and a graphics load failure.