fix: improve Service and AdapterService types#1567
Merged
daffl merged 2 commits intofeathersjs:masterfrom Oct 10, 2019
Merged
Conversation
d247ea8 to
0822c38
Compare
0822c38 to
7453c41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type multi usages of
create/update/patch/removeinServiceMethods,ServiceOverloadsandAdapterService.Remove this
patch()overload fromServiceOverloads. It does not do anything really.In
AdapterServiceremovedPromise<T>as possible result offind()method, since no adapter does that (or am i wrong?). Small breaking change, super easily fixed by removingT |from types of adapters in_findmethods.