Skip to content

feat: Allow reAuthentication using specific strategy #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 1 commit into from
Dec 5, 2020
Merged

feat: Allow reAuthentication using specific strategy #2140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/authentication-client/src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export class AuthenticationClient {
return Promise.reject(error);
}

reAuthenticate (force: boolean = false): Promise<AuthenticationResult> {
reAuthenticate (force: boolean = false, strategy?: string): Promise<AuthenticationResult> {
// Either returns the authentication state or
// tries to re-authenticate with the stored JWT and strategy
const authPromise = this.app.get('authentication');
Expand All @@ -144,7 +144,7 @@ export class AuthenticationClient {
}

return this.authenticate({
strategy: this.options.jwtStrategy,
strategy: strategy || this.options.jwtStrategy,
accessToken
});
});
Expand Down
22 changes: 22 additions & 0 deletions packages/authentication-client/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,5 +202,27 @@ describe('@feathersjs/authentication-client', () => {
assert.ok(!app.get('authentication'));
});
});

it('reauthenticates using different strategy', async () => {
app.configure(client({ jwtStrategy: 'any' }));

const data = {
strategy: 'testing'
};

let result = await app.authenticate(data);
assert.deepStrictEqual(result, {
accessToken,
data,
user
});

result = await app.authentication.reAuthenticate(false, 'jwt');
assert.deepStrictEqual(result, {
accessToken,
data,
user
});
})
});
});