Skip to content

Docs for MALLOC_CONF#5645

Merged
anandbraman merged 1 commit intomainfrom
anandraman/fde-16-malloc_conf-env-var-overrides-pipeline-configured-value
Feb 25, 2026
Merged

Docs for MALLOC_CONF#5645
anandbraman merged 1 commit intomainfrom
anandraman/fde-16-malloc_conf-env-var-overrides-pipeline-configured-value

Conversation

@anandbraman
Copy link
Contributor

@anandbraman anandbraman commented Feb 17, 2026 •
edited
Loading

Describe Manual Test Plan

Built docs locally, confirmed linkbacks

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

Mark if you think the answer is yes for any of these components:

Describe Incompatible Changes

@anandbraman anandbraman requested a review from gz February 17, 2026 16:59
mihaibudiu
mihaibudiu reviewed Feb 17, 2026
View reviewed changes
docs.feldera.com/README.md

### Installation

Install yarn if not already present. Then install required dependencies & setup project.
Copy link
Contributor

@mihaibudiu mihaibudiu Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed an issue about this: the docs seem to require node 18, while the rest of the project requires node 20.
At least I cannot build the docs with node 25.

gz
gz approved these changes Feb 17, 2026
View reviewed changes
@gz
Copy link
Contributor

gz commented Feb 17, 2026 •
edited
Loading

It might also be good to mention that we set a default malloc conf here

feldera/sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/backend/rust/BaseRustCodeGenerator.java

Line 103 in 5bcdf94

pub static malloc_conf: &[u8] = b"prof:true,prof_active:true,lg_prof_sample:19\\0";""";

so if people override it, it would be good to preserve those settings in their config to make sure heap profiles continue to work

@anandbraman anandbraman added this pull request to the merge queue Feb 18, 2026
@gz gz removed this pull request from the merge queue due to a manual request Feb 18, 2026
@gz
Copy link
Contributor

gz commented Feb 18, 2026

can you squash the commit into a single one (with a commit message something like [docs] what I did)

@anandbraman anandbraman force-pushed the anandraman/fde-16-malloc_conf-env-var-overrides-pipeline-configured-value branch 2 times, most recently from 0604fac to 7820251 Compare February 19, 2026 15:37
@anandbraman anandbraman added this pull request to the merge queue Feb 20, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2026
@anandbraman anandbraman force-pushed the anandraman/fde-16-malloc_conf-env-var-overrides-pipeline-configured-value branch from 7820251 to 4a97be6 Compare February 20, 2026 18:52
@anandbraman anandbraman added this pull request to the merge queue Feb 20, 2026
@gz
Copy link
Contributor

gz commented Feb 20, 2026

@anandbraman I think there is a bug here because there shouldn't be a - in the example before value

@gz gz removed this pull request from the merge queue due to a manual request Feb 20, 2026
mythical-fred
mythical-fred suggested changes Feb 20, 2026
View reviewed changes
Copy link
Collaborator

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is a welcome addition — jemalloc tuning is a real operational need and this fills a real gap. But there's one functional bug in the Helm example that would confuse enterprise users, and the commit message needs a body. Details inline.

@anandbraman anandbraman force-pushed the anandraman/fde-16-malloc_conf-env-var-overrides-pipeline-configured-value branch from 33042f3 to 8a6f749 Compare February 24, 2026 19:34
@anandbraman anandbraman added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 2b2be9b Feb 25, 2026
1 check passed
@anandbraman anandbraman deleted the anandraman/fde-16-malloc_conf-env-var-overrides-pipeline-configured-value branch February 25, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaibudiu mihaibudiu mihaibudiu left review comments

@gz gz gz approved these changes

+1 more reviewer

@mythical-fred mythical-fred mythical-fred requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anandbraman @gz @mihaibudiu @mythical-fred